fix(rust/signed-doc): Apply new DocType
#347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
bkioshn
changed the title
DocType
Signed-off-by: bkioshn <[email protected]>
bkioshn
changed the title
DocTypeDocType
|
✅ Test Report | |
Signed-off-by: bkioshn <[email protected]>
Mr-Leshiy
requested changes
May 28, 2025
There was a problem hiding this comment.
Also could you update proposal.rs, comment.rs and submission.rs tests with applying new doc type ids and also remain at least one test case with the old types.
e.g.
for the proposal.rs inside test_valid_proposal_doc, test_valid_proposal_doc_with_empty_provider and test_invalid_proposal_doc update "type" field definition to the new one (as array with multiple values), and also add one more new test test_valid_proposal_doc_old_type with preserving current test case with the old type definition.
(the same thing do for the comment.rs and submission.rs)
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Mr-Leshiy
reviewed
May 29, 2025
Mr-Leshiy
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply new
DocTypeto existingtypefieldRelated Issue(s)
Closes #328
Breaking Changes
There shouldn't be any breaking change since it should be backward compatible.
Related Pull Requests
#339
Please confirm the following checks